web: remove const qualifier for getMaterialInstances #6952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainguy
reviewed
Jul 13, 2023
web/filament-js/filament.d.ts
Outdated
| @@ -624,7 +624,7 @@ export class gltfio$FilamentInstance { | |||
| public getSkinNames(): Vector<string>; | |||
| public attachSkin(skinIndex: number, entity: Entity): void; | |||
| public detachSkin(skinIndex: number, entity: Entity): void; | |||
| public getMaterialInstances(): Vector<MaterialInstance>; | |||
There was a problem hiding this comment.
Why this change here? The other getters return a Vector<>.
There was a problem hiding this comment.
getMaterialVariantNames is wrapper by vectorToArray, which is convenient when iterate, so make this change to getMaterialInstances too.
What's the convention (vectorToArray or not) here, should all interfaces defined in filament.d.ts use Vector?
There was a problem hiding this comment.
I think we should keep this consistent with the other APIs and continue to return a Vector<MaterialInstance>.
bejado
requested changes
Jul 17, 2023
web/filament-js/filament.d.ts
Outdated
| @@ -624,7 +624,7 @@ export class gltfio$FilamentInstance { | |||
| public getSkinNames(): Vector<string>; | |||
| public attachSkin(skinIndex: number, entity: Entity): void; | |||
| public detachSkin(skinIndex: number, entity: Entity): void; | |||
| public getMaterialInstances(): Vector<MaterialInstance>; | |||
There was a problem hiding this comment.
I think we should keep this consistent with the other APIs and continue to return a Vector<MaterialInstance>.
mackong
force-pushed
the
fix/const-material-instance
branch
from
489bce1
to
97adec4
Compare
mackong
force-pushed
the
fix/const-material-instance
branch
from
97adec4
to
12d306b
Compare
bejado
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the const qualifier on the returned MaterialInstances, we cannot call setter functions like setDepthWrite etc. from the object, caused by